Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore(dui3): Add WorkspaceId to model card #236

Merged
merged 2 commits into from
Sep 16, 2024

Conversation

oguzhankoral
Copy link
Member

@oguzhankoral oguzhankoral commented Sep 12, 2024

Tested. Merging specklesystems/speckle-server#3008, is harmless for connectors in production. They just won't be able to store workspaceId of the saved model card. It just send workpsace_id whenever the model card first created

it is needed to store information between sessions
Copy link

codecov bot commented Sep 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 7.32%. Comparing base (eb8f8de) to head (6a46606).
Report is 1 commits behind head on dev.

Additional details and impacted files
@@          Coverage Diff          @@
##             dev    #236   +/-   ##
=====================================
  Coverage   7.32%   7.32%           
=====================================
  Files        242     242           
  Lines       4708    4708           
  Branches     548     548           
=====================================
  Hits         345     345           
  Misses      4348    4348           
  Partials      15      15           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@oguzhankoral oguzhankoral merged commit cc285e9 into dev Sep 16, 2024
5 checks passed
@oguzhankoral oguzhankoral deleted the oguzhan/add-workspace-id-to-model-card branch September 16, 2024 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants