Add Result objects for Rhino

Connectors/Rhino/Speckle.Connectors.RhinoShared/Operations/Receive/RhinoHostObjectBuilder.cs

@@ -147,15 +147,21 @@ CancellationToken cancellationToken
 
             // 2: convert
             var result = _converter.Convert(obj);
+            if (!result.IsSuccess)
+            {
+              conversionResults.Add(new(Status.ERROR, obj,  result.Message.NotNull()));
+              convertActivity?.SetStatus(SdkActivityStatusCode.Error);
+              continue;
+            }
 
             // 3: bake
             var conversionIds = new List<string>();
-            if (result is GeometryBase geometryBase)
+            if (result.Host is GeometryBase geometryBase)
             {
               var guid = BakeObject(geometryBase, obj, null, atts);
               conversionIds.Add(guid.ToString());
             }
-            else if (result is List<GeometryBase> geometryBases) // one to many raw encoding case
+            else if (result.Host is List<GeometryBase> geometryBases) // one to many raw encoding case
             {
               // NOTE: I'm unhappy about this case (dim). It's needed as the raw encoder approach can hypothetically return
               // multiple "geometry bases" - but this is not a fallback conversion.
@@ -167,7 +173,7 @@ CancellationToken cancellationToken
                 conversionIds.Add(guid.ToString());
               }
             }
-            else if (result is IEnumerable<(object, Base)> fallbackConversionResult) // one to many fallback conversion
+            else if (result.Host is IEnumerable<(object, Base)> fallbackConversionResult) // one to many fallback conversion
             {
               var guids = BakeObjectsAsFallbackGroup(fallbackConversionResult, obj, atts, baseLayerName);
               conversionIds.AddRange(guids.Select(id => id.ToString()));

Connectors/Rhino/Speckle.Connectors.RhinoShared/Operations/Send/RhinoRootObjectBuilder.cs

@@ -11,6 +11,7 @@
 using Speckle.Converters.Common;
 using Speckle.Converters.Rhino;
 using Speckle.Sdk;
+using Speckle.Sdk.Common;
 using Speckle.Sdk.Logging;
 using Speckle.Sdk.Models;
 using Speckle.Sdk.Models.Collections;
@@ -159,8 +160,17 @@ string projectId
       }
       else
       {
-        converted = _rootToSpeckleConverter.Convert(rhinoObject);
-        converted.applicationId = applicationId;
+        var result  = _rootToSpeckleConverter.Convert(rhinoObject);
+        if (result.IsSuccess)
+        {
+          converted = result.Base.NotNull();
+          converted.applicationId = applicationId;
+        }
+        else
+        {
+          _logger.LogSendConversionError(sourceType, result.Message.NotNull());
+          return new(Status.ERROR, applicationId, sourceType);
+        }
       }
 
       // add to host

Converters/Rhino/Speckle.Converters.RhinoShared/SpeckleToHostGeometryBaseTopLevelConverter.cs

@@ -1,5 +1,6 @@
 using Speckle.Converters.Common;
 using Speckle.Converters.Common.Objects;
+using Speckle.Converters.Common.Registration;
 using Speckle.Sdk.Common;
 using Speckle.Sdk.Common.Exceptions;
 using Speckle.Sdk.Models;
@@ -21,7 +22,7 @@ ITypedConverter<TIn, TOut> geometryBaseConverter
     _geometryBaseConverter = geometryBaseConverter;
   }
 
-  public object Convert(Base target)
+  public HostResult Convert(Base target)
   {
     var castedBase = (TIn)target;
     var result = _geometryBaseConverter.Convert(castedBase);
@@ -37,7 +38,7 @@ public object Convert(Base target)
     if (result is RG.GeometryBase geometryBase && units is not null)
     {
       geometryBase.Transform(GetScaleTransform(units));
-      return geometryBase;
+      return HostResult.Success(geometryBase);
     }
 
     if (result is List<RG.GeometryBase> geometryBases && units is not null)
@@ -48,10 +49,10 @@ public object Convert(Base target)
         gb.Transform(t);
       }
 
-      return geometryBases;
+      return HostResult.Success(geometryBases);
     }
 
-    return result;
+    return HostResult.Success(result);
   }
 
   private RG.Transform GetScaleTransform(string from)

Converters/Rhino/Speckle.Converters.RhinoShared/ToHost/TopLevel/FallbackToHostTopLevelConverter.cs

@@ -1,5 +1,6 @@
 using Speckle.Converters.Common;
 using Speckle.Converters.Common.Objects;
+using Speckle.Converters.Common.Registration;
 using Speckle.Sdk.Common;
 using Speckle.Sdk.Common.Exceptions;
 using Speckle.Sdk.Models;
@@ -35,7 +36,7 @@ IConverterSettingsStore<RhinoConversionSettings> settingsStore
     _settingsStore = settingsStore;
   }
 
-  public object Convert(Base target) => Convert((DisplayableObject)target);
+  public HostResult Convert(Base target) => HostResult.Success(Convert((DisplayableObject)target));
 
   public List<RG.GeometryBase> Convert(DisplayableObject target)
   {

Converters/Rhino/Speckle.Converters.RhinoShared/ToSpeckle/TopLevel/BrepObjectToSpeckleTopLevelConverter.cs

@@ -1,9 +1,9 @@
 using Rhino.DocObjects;
 using Speckle.Converters.Common;
 using Speckle.Converters.Common.Objects;
+using Speckle.Converters.Common.Registration;
 using Speckle.Converters.Rhino.ToSpeckle.Encoding;
 using Speckle.Converters.Rhino.ToSpeckle.Meshing;
-using Speckle.Sdk.Models;
 
 namespace Speckle.Converters.Rhino.ToSpeckle.TopLevel;
 
@@ -22,7 +22,7 @@ IConverterSettingsStore<RhinoConversionSettings> settingsStore
     _settingsStore = settingsStore;
   }
 
-  public Base Convert(object target)
+  public BaseResult Convert(object target)
   {
     var brepObject = (BrepObject)target;
     var brepEncoding = RawEncodingCreator.Encode(brepObject.Geometry, _settingsStore.Current.Document);
@@ -37,6 +37,6 @@ public Base Convert(object target)
       units = _settingsStore.Current.SpeckleUnits
     };
 
-    return bx;
+    return BaseResult.Success(bx);
   }
 }

Converters/Rhino/Speckle.Converters.RhinoShared/ToSpeckle/TopLevel/ExtrusionObjectToSpeckleTopLevelConverter.cs

@@ -1,9 +1,9 @@
 using Rhino.DocObjects;
 using Speckle.Converters.Common;
 using Speckle.Converters.Common.Objects;
+using Speckle.Converters.Common.Registration;
 using Speckle.Converters.Rhino.ToSpeckle.Encoding;
 using Speckle.Converters.Rhino.ToSpeckle.Meshing;
-using Speckle.Sdk.Models;
 
 namespace Speckle.Converters.Rhino.ToSpeckle.TopLevel;
 
@@ -22,7 +22,7 @@ IConverterSettingsStore<RhinoConversionSettings> settingsStore
     _settingsStore = settingsStore;
   }
 
-  public Base Convert(object target)
+  public BaseResult Convert(object target)
   {
     var extrusionObject = (ExtrusionObject)target;
     var extrusionEncoding = RawEncodingCreator.Encode(extrusionObject.Geometry, _settingsStore.Current.Document);
@@ -37,6 +37,6 @@ public Base Convert(object target)
       units = _settingsStore.Current.SpeckleUnits
     };
 
-    return bx;
+    return BaseResult.Success(bx);
   }
 }

Converters/Rhino/Speckle.Converters.RhinoShared/ToSpeckle/TopLevel/RhinoObjectToSpeckleTopLevelConverter.cs

@@ -1,4 +1,5 @@
 using Speckle.Converters.Common.Objects;
+using Speckle.Converters.Common.Registration;
 using Speckle.Sdk.Models;
 using RhinoObject = Rhino.DocObjects.RhinoObject;
 
@@ -19,7 +20,7 @@ protected RhinoObjectToSpeckleTopLevelConverter(ITypedConverter<TInRaw, TOutRaw>
   // POC: IIndex would fix this as I would just request the type from `RhinoObject.Geometry` directly.
   protected abstract TInRaw GetTypedGeometry(TTopLevelIn input);
 
-  public virtual Base Convert(object target)
+  public  BaseResult Convert(object target)
   {
     var typedTarget = (TTopLevelIn)target;
     var typedGeometry = GetTypedGeometry(typedTarget);
@@ -33,6 +34,6 @@ public virtual Base Convert(object target)
       result["name"] = typedTarget.Attributes.Name;
     }
 
-    return result;
+    return BaseResult.Success( result);
   }
 }

Converters/Rhino/Speckle.Converters.RhinoShared/ToSpeckle/TopLevel/SubDObjectToSpeckleTopLevelConverter.cs

@@ -1,9 +1,9 @@
 using Rhino.DocObjects;
 using Speckle.Converters.Common;
 using Speckle.Converters.Common.Objects;
+using Speckle.Converters.Common.Registration;
 using Speckle.Converters.Rhino.ToSpeckle.Encoding;
 using Speckle.Converters.Rhino.ToSpeckle.Meshing;
-using Speckle.Sdk.Models;
 
 namespace Speckle.Converters.Rhino.ToSpeckle.TopLevel;
 
@@ -22,7 +22,7 @@ IConverterSettingsStore<RhinoConversionSettings> settingsStore
     _settingsStore = settingsStore;
   }
 
-  public Base Convert(object target)
+  public BaseResult Convert(object target)
   {
     var subDObject = (SubDObject)target;
     var subdEncoding = RawEncodingCreator.Encode(subDObject.Geometry, _settingsStore.Current.Document);
@@ -37,6 +37,6 @@ public Base Convert(object target)
       units = _settingsStore.Current.SpeckleUnits
     };
 
-    return bx;
+    return BaseResult.Success(bx);
   }
 }

Sdk/Speckle.Connectors.Common/Conversion/ReportResult.cs

@@ -55,6 +55,18 @@ public ReceiveConversionResult(
     ResultType = resultType;
     Error = FormatError(exception);
   }
+
+  public ReceiveConversionResult(
+    Status status,
+    Base source,
+    string exception
+  )
+  {
+    Status = status;
+    SourceId = source.id.NotNull();
+    SourceType = source.speckle_type; // Note: we'll parse it nicely in FE
+    Error = new ErrorWrapper() { Message = exception, StackTrace = "" };
+  }
 }
 
 /// <summary>

Sdk/Speckle.Connectors.Common/Extensions/RootObjectBuilderExtensions.cs

@@ -20,4 +20,13 @@ string objectType
 
     logger.Log(logLevel, ex, "Conversion of object {objectType} was not successful", objectType);
   }
+
+  public static void LogSendConversionError<T>(
+    this ILogger<IRootObjectBuilder<T>> logger,
+    string objectType,
+    string message
+  )
+  {
+    logger.Log(LogLevel.Information, "Conversion of object {objectType} was not successful:" + message, objectType);
+  }
 }

Sdk/Speckle.Converters.Common/Extensions/ToHostTopLevelConverterExtension.cs

@@ -1,13 +1,54 @@
 using Microsoft.Extensions.Logging;
 using Speckle.Converters.Common.Objects;
+using Speckle.Converters.Common.Registration;
 using Speckle.Sdk;
+using Speckle.Sdk.Common;
 using Speckle.Sdk.Models;
 
 namespace Speckle.Converters.Common.Extensions;
 
 public static class ToHostTopLevelConverterExtension
 {
-  public static object ConvertAndLog(this IToHostTopLevelConverter converter, Base target, ILogger logger)
+  public static HostResult ConvertAndLog(this ConverterResult<IToHostTopLevelConverter> converter, Base target, ILogger logger)
+  {
+    try
+    {
+      if (converter.IsSuccess)
+      {
+        return converter.Converter.NotNull().Convert(target);
+      }
+
+      logger.Log(
+        LogLevel.Information,
+        "Conversion of object {target} using {converter} was not successful",
+        target.GetType(),
+        converter.GetType()
+      );
+      return HostResult.NoConverter(converter.Message);
+    }
+#pragma warning disable CA1031
+    catch (Exception ex)
+#pragma warning restore CA1031
+    {
+      //SpeckleExceptions are expected, if a converter throws anything else, its considered an error that we should investigate and fix
+      LogLevel logLevel = ex switch
+      {
+        SpeckleException => LogLevel.Information, //If it's too noisy, we could demote to LogLevel.Debug
+        _ => LogLevel.Error
+      };
+
+      logger.Log(
+        logLevel,
+        ex,
+        "Conversion of object {target} using {converter} was not successful",
+        target.GetType(),
+        converter.GetType()
+      );
+
+      return HostResult.NoConversion($"Conversion of object {target} using {converter} was not successful: " + ex.Message);
+    }
+  }
+  public static HostResult ConvertAndLog(this IToHostTopLevelConverter converter, Base target, ILogger logger)
   {
     try
     {

Sdk/Speckle.Converters.Common/IRootToHostConverter.cs

@@ -1,8 +1,9 @@
+using Speckle.Converters.Common.Registration;
 using Speckle.Sdk.Models;
 
 namespace Speckle.Converters.Common;
 
 public interface IRootToHostConverter
 {
-  object Convert(Base target);
+  HostResult Convert(Base target);
 }

Sdk/Speckle.Converters.Common/Objects/IToHostTopLevelConverter.cs

@@ -1,8 +1,9 @@
+using Speckle.Converters.Common.Registration;
 using Speckle.Sdk.Models;
 
 namespace Speckle.Converters.Common.Objects;
 
 public interface IToHostTopLevelConverter
 {
-  object Convert(Base target);
+  HostResult Convert(Base target);
 }

Sdk/Speckle.Converters.Common/Objects/IToSpeckleTopLevelConverter.cs

@@ -1,8 +1,8 @@
-using Speckle.Sdk.Models;
+using Speckle.Converters.Common.Registration;
 
 namespace Speckle.Converters.Common.Objects;
 
 public interface IToSpeckleTopLevelConverter
 {
-  Base Convert(object target);
+  BaseResult Convert(object target);
 }

Sdk/Speckle.Converters.Common/Registration/ConverterManager.cs

@@ -1,15 +1,15 @@
 using System.Collections.Concurrent;
 using Microsoft.Extensions.DependencyInjection;
-using Speckle.Sdk.Common.Exceptions;
 
 namespace Speckle.Converters.Common.Registration;
 
+
 public class ConverterManager<T>(ConcurrentDictionary<string, Type> converterTypes, IServiceProvider serviceProvider)
   : IConverterManager<T>
 {
   public string Name => typeof(T).Name;
 
-  public T ResolveConverter(Type type, bool recursive = true)
+  public ConverterResult<T> ResolveConverter(Type type, bool recursive = true)
   {
     var currentType = type;
     while (true)
@@ -23,16 +23,17 @@ public T ResolveConverter(Type type, bool recursive = true)
 
         if (currentType == null)
         {
-          throw new ConversionNotSupportedException($"No conversion found for {type.Name} or any of its base types");
+          return new ConverterResult<T>(ConversionStatus.NoConverter, Message: $"No conversion found for {type.Name} or any of its base types");
         }
       }
       else if (converter is null)
       {
-        throw new ConversionNotSupportedException($"No conversion found for {type.Name}");
+        return new ConverterResult<T>(ConversionStatus.NoConverter, Message: $"No conversion found for {type.Name}");
       }
       else
       {
-        return converter;
+
+        return new ConverterResult<T>(ConversionStatus.Success, converter);
       }
     }
   }