Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Xmas: Let it snow #3731

Merged
merged 9 commits into from
Dec 20, 2024
Merged

Xmas: Let it snow #3731

merged 9 commits into from
Dec 20, 2024

Conversation

Mikehrn
Copy link
Contributor

@Mikehrn Mikehrn commented Dec 20, 2024

Screenshot 2024-12-20 at 14 27 14

iainsproat
iainsproat previously approved these changes Dec 20, 2024
Copy link
Contributor

@benjaminvo benjaminvo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't toggle away from the view mode again. Stuck here:
CleanShot 2024-12-20 at 14 34 40@2x

@Mikehrn
Copy link
Contributor Author

Mikehrn commented Dec 20, 2024

Can't toggle away from the view mode again. Stuck here: CleanShot 2024-12-20 at 14 34 40@2x

I just fixed that, @AlexandruPopovici is going to make another change when he is back to remove the snow from the modal once you change viewmode

@benjaminvo
Copy link
Contributor

I just fixed that, @AlexandruPopovici is going to make another change when he is back to remove the snow from the modal once you change viewmode

For performance reasons? Because I actually like that the snow stays on the model when toggling off the view mode again

@Mikehrn
Copy link
Contributor Author

Mikehrn commented Dec 20, 2024

I just fixed that, @AlexandruPopovici is going to make another change when he is back to remove the snow from the modal once you change viewmode

For performance reasons? Because I actually like that the snow stays on the model when toggling off the view mode again

It's kinda cool yeah, we can also keep it

@Mikehrn Mikehrn requested a review from benjaminvo December 20, 2024 13:44
benjaminvo
benjaminvo previously approved these changes Dec 20, 2024
benjaminvo
benjaminvo previously approved these changes Dec 20, 2024
didimitrie
didimitrie previously approved these changes Dec 20, 2024
@Mikehrn Mikehrn merged commit d54eeb5 into main Dec 20, 2024
26 of 28 checks passed
@Mikehrn Mikehrn deleted the mike/let-it-snow branch December 20, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants