Gergo/web 2124 set up email notifications for trial expiration #3703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gergo/web-2124-set-up-email-notifications-for-trial-expiration
…gergo/web-2124-set-up-email-notifications-for-trial-expiration
benjaminvo
reviewed
Dec 17, 2024
| plan: 'starter', | ||
| status: 'trial' | ||
| }) | ||
| if (trialWorkspacesExpireIn14Days.length) { |
There was a problem hiding this comment.
@alemagio I think we can remove the 14 days email for now. I initially wanted it but now I think it's a little too much to send it this long time before the trial ends. 3 days before and on the same day is enough for now.
Maybe we will send another type of email 14 days before just to check in with the user, but that can be a separate task. Additionally we'll also be adding more automated emails after the trial has expired to try and reactive the workspace. But also a separate task.
benjaminvo
reviewed
Dec 17, 2024
| const url = new URL(`workspaces/${args.workspace.slug}`, getServerOrigin()).toString() | ||
| return { | ||
| mjml: buildMjmlBody(args), | ||
| text: buildTextBody(), |
There was a problem hiding this comment.
What's up with this? It looks like buildTextBody() above doesn't return anything.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.