Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(knex): adds comments around config choices. No code changes #3696

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

iainsproat
Copy link
Contributor

@iainsproat iainsproat commented Dec 14, 2024

Description & motivation

Provides more commentary around the choice of configuration values for Tarn. Also provides commentary as to why some default values should not be amended.

Changes:

To-do before merge:

Screenshots:

Validation of changes:

Checklist:

  • My pull request follows the guidelines in the Contributing guide?
  • My pull request does not duplicate any other open Pull Requests for the same update/change?
  • My commits are related to the pull request and do not amend unrelated code or documentation.
  • My code follows a similar style to existing code.
  • I have added appropriate tests.
  • I have updated or added relevant documentation.

References

@iainsproat iainsproat marked this pull request as ready for review December 14, 2024 10:28
Copy link
Contributor

📸 Preview service has generated an image.

@iainsproat iainsproat merged commit 89caea3 into main Dec 16, 2024
28 of 30 checks passed
@iainsproat iainsproat deleted the iain/connection-pool-tarn-retry branch December 16, 2024 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants