Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description & motivation
Handles https://linear.app/speckle/issue/WEB-2333/instances-dont-update-their-shadow-when-being-moved-or-filtered-or
SpeckleInstancedMesh
now recreat the shadow depth material for all instances whenever the instance configuration changes as a result of selection/filtering/anything elseExtendedSelection
extension now properly resets rendering pipelines so no residual AO is leftChanges:
To-do before merge:
Screenshots:
Screenshots won't do, but video will.
Before (notice how the shadows disappear when the toilet is moved and how no shadows are cast by the wall on the toilets) :
bandicam.2024-12-12.14-15-20-408.mp4
After (the above issues are now fixed)
bandicam.2024-12-12.14-12-54-546.mp4
Validation of changes:
Checklist:
References