Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instances Shadows Fix #3681

Merged
merged 1 commit into from
Dec 12, 2024
Merged

Instances Shadows Fix #3681

merged 1 commit into from
Dec 12, 2024

Conversation

AlexandruPopovici
Copy link
Contributor

@AlexandruPopovici AlexandruPopovici commented Dec 12, 2024

Description & motivation

Handles https://linear.app/speckle/issue/WEB-2333/instances-dont-update-their-shadow-when-being-moved-or-filtered-or

  • SpeckleInstancedMesh now recreat the shadow depth material for all instances whenever the instance configuration changes as a result of selection/filtering/anything else
  • Also the ExtendedSelection extension now properly resets rendering pipelines so no residual AO is left

Changes:

To-do before merge:

Screenshots:

Screenshots won't do, but video will.

Before (notice how the shadows disappear when the toilet is moved and how no shadows are cast by the wall on the toilets) :

bandicam.2024-12-12.14-15-20-408.mp4

After (the above issues are now fixed)

bandicam.2024-12-12.14-12-54-546.mp4

Validation of changes:

Checklist:

  • My pull request follows the guidelines in the Contributing guide?
  • My pull request does not duplicate any other open Pull Requests for the same update/change?
  • My commits are related to the pull request and do not amend unrelated code or documentation.
  • My code follows a similar style to existing code.
  • I have added appropriate tests.
  • I have updated or added relevant documentation.

References

Copy link

linear bot commented Dec 12, 2024

Copy link
Contributor

📸 Preview service has generated an image.

Copy link
Contributor

@iainsproat iainsproat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved on the basis it looks like legitimate viewer changes.
Would be nice to see some before and after screenshots in these PRs.

@AlexandruPopovici
Copy link
Contributor Author

AlexandruPopovici commented Dec 12, 2024

Approved on the basis it looks like legitimate viewer changes. Would be nice to see some before and after screenshots in these PRs.

Indeed. I've added videos as screenshots are not able to show the issue @iainsproat

@AlexandruPopovici AlexandruPopovici merged commit 9e0e6a9 into main Dec 12, 2024
28 of 30 checks passed
@AlexandruPopovici AlexandruPopovici deleted the alex/WEB-2333 branch December 12, 2024 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants