feature(fe2): View mode FE integration #3651
Conversation
| const handler = handlers[shortcut.action as ViewerShortcutAction] | ||
| if (handler) { | ||
| onKeyboardShortcut([...shortcut.modifiers], shortcut.key, () => { | ||
| if (!isTypingComment.value) handler() |
There was a problem hiding this comment.
@andrewwallacespeckle I guess this will not block shortcuts when typing elsewhere (feedback modal, filter input etc?)
There was a problem hiding this comment.
Good question, will double check and test this. Will leave unresolved until I do
There was a problem hiding this comment.
I used VueUse here and it seems to work well. You can check it out in this commit:
5a68e55
|
📸 Preview service has generated an image. |
|
📸 Preview service has generated an image. |
|
📸 Preview service has generated an image. |
| } | ||
| }) | ||
| } | ||
| } |
There was a problem hiding this comment.
Yup, this extension was here mostly as a placeholder for the frontend. Removing it is the way to go 👍
| @@ -48,5 +63,7 @@ export class ViewModes extends Extension { | |||
| break | |||
| } | |||
| this.viewer.requestRender(UpdateFlags.RENDER_RESET) | |||
|
|
|||
| this.emit(ViewModeEvent.Changed, viewMode) | |||
| } | |||
| } | |||
There was a problem hiding this comment.
I like the approach of defining it's own events here! 👍
|
📸 Preview service has generated an image. |
| } | ||
| } as const | ||
|
|
||
| export const ToolShortcuts = { |
There was a problem hiding this comment.
It's not a must, but you can add : readonly, then TS will complain if you try to modify these consts, I started using that for consts that shouldn't change as well
|
📸 Preview service has generated an image. |
|
📸 Preview service has generated an image. |
|
📸 Preview service has generated an image. |
|
📸 Preview service has generated an image. |
andrewwallacespeckle
deleted the
andrew/web-2119-add-view-mode-selector
branch
Description & motivation
Changes:
To-do before merge:
Screenshots:
Validation of changes:
Checklist:
References