Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(sso): disable slug edit if sso enabled #3621

Merged
merged 3 commits into from
Dec 3, 2024
Merged

fix(sso): disable slug edit if sso enabled #3621

merged 3 commits into from
Dec 3, 2024

Conversation

cdriesler
Copy link
Member

Description & motivation

  • SSO is currently configured with redirects specific to a workspace slug. If the slug changes, SSO breaks. If SSO breaks and your session expires, you're locked out.

Changes:

  • Disable slug edit on FE & BE if SSO is configured

image

andrewwallacespeckle
andrewwallacespeckle previously approved these changes Dec 3, 2024
View reviewed changes
Copy link
Contributor

@andrewwallacespeckle andrewwallacespeckle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Frontend looks good

@cdriesler cdriesler merged commit b4aa0f7 into main Dec 3, 2024
26 of 28 checks passed
@cdriesler cdriesler deleted the charles/ssoSlugs branch December 3, 2024 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iainsproat iainsproat iainsproat approved these changes

@andrewwallacespeckle andrewwallacespeckle andrewwallacespeckle left review comments

@Mikehrn Mikehrn Awaiting requested review from Mikehrn

@gjedlicska gjedlicska Awaiting requested review from gjedlicska

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cdriesler @iainsproat @andrewwallacespeckle