feat(projects): filter projects, that are not available under sso #3585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gergo/filterSsoProtectedProjects
…systems/speckle-server into gergo/filterSsoProtectedProjects
fabis94
reviewed
Dec 2, 2024
|
@fabis94 could you double check, that the (Stream|Project)Collection -> User(Stream|Project)Collection changes are not breaking anything on the frontend / type system. I've tested with FE2, DUI3 and DUI2 things were working, but i'd like your stamp on this too. |
fabis94
requested changes
Dec 3, 2024
| // a little escape hatch for admins to look into users streams | ||
| // const forOtherUser = parent.id !== ctx.userId | ||
| const isAdmin = adminOverrideEnabled() && ctx.role === Roles.Server.Admin | ||
| const forOtherUser = !isAdmin |
There was a problem hiding this comment.
Is this correct? Only show other user's streams if not an admin? Surely it's the inverse? @gjedlicska
|
the CI's failing, you probably have to merge in main |
fabis94
previously approved these changes
Dec 3, 2024
…systems/speckle-server into gergo/filterSsoProtectedProjects
fabis94
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description & motivation
Changes:
To-do before merge:
Screenshots:
Validation of changes:
Checklist:
References