Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(server): remove flaky dblink_slot_create_or_drop calls in tests #3515

Merged
merged 1 commit into from
Nov 19, 2024

Conversation

fabis94
Copy link
Contributor

@fabis94 fabis94 commented Nov 19, 2024

@gjedlicska
Copy link
Contributor

Will the DB in test and dev envs have enough replication slots to not delete the subs?
@fabis94 @iainsproat ?

@fabis94
Copy link
Contributor Author

fabis94 commented Nov 19, 2024

@gjedlicska we're still deleting the subs, we're just not explicitly deleting the slots after. it's not clear if that's even necessary, we added that while troubleshooting the original multiregion test issues, but there's been no signs so far that we actually need it - I mean you would think that deleting a subscription would also delete its slot.

If NOT, then the only alternative we have is to introduce delays/waits into the mix, which I did not want to do until we're sure this doesn't work

@iainsproat
Copy link
Contributor

aiven_extras.pg_drop_subscription which is called in the line above already drops the replication slot by default, so we don't need to duplicate it and we can delete this commented out line.
https://github.com/aiven/aiven-extras/blob/c51cbeb127acef663c53dbe89d2726d9109e421b/sql/aiven_extras.sql#L223

@fabis94
Copy link
Contributor Author

fabis94 commented Nov 19, 2024

lets merge and monitor this first before we remove that line altogether

@fabis94 fabis94 merged commit c40693e into main Nov 19, 2024
26 of 28 checks passed
@fabis94 fabis94 deleted the fabians/fix-multiregion-test-flakiness1 branch November 19, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants