gergo/web 2158 previews module multi region #3492
Conversation
|
📸 Preview service has generated an image. |
|
@iainsproat i'd like to get some help fixing the preview service test job. It does not work the way you set it up any more. We cannot inject the DB all the way down cause of multi region project selection I've tested locally, and both mainDb and regional previews are generated. |
|
📸 Preview service has generated an image. |
| } | ||
|
|
||
| start() | ||
| .then() |
There was a problem hiding this comment.
the .then()/.catch() bits are redundant
|
|
||
| const isDevEnv = process.env.NODE_ENV === 'development' | ||
|
|
||
| export const getDbClients = async () => { |
There was a problem hiding this comment.
this is already better than it was, but in the future we can probably even extract a lot of this DB querying/"repository" logic that is common between these BG services into shared as well
There was a problem hiding this comment.
I think in future, preview service should be given a short-lived API token and call the API on the server instead of duplicating the objects stuff.
But that's a discussion & refactor for the future, not one to hold up this PR.
…gergo/web-2158-previews-module-multi-region
|
📸 Preview service has generated an image. |
|
📸 Preview service has generated an image. |
Description & motivation
Changes:
To-do before merge:
Screenshots:
Validation of changes:
Checklist:
References