fix(POST /api/file): REST API endpoint returns json content-type #3463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iainsproat
commented
Nov 8, 2024
| res | ||
| .status(400) | ||
| .end( | ||
| '{ "error": "Upload request error. The server logs may have more details." }' |
There was a problem hiding this comment.
Does this have implications for the frontend?
| res.status(400).end('Upload request error. The server logs have more details') | ||
| res | ||
| .status(400) | ||
| .end('{"error": "Upload request error. The server logs have more details."}') |
There was a problem hiding this comment.
Does this change have implications for the frontend?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description & motivation
Calls to
POST /api/file/:fileType/:streamId/:branchName?returned an incorrect content-type header in its response.The
application/jsoncontent-type is now returned.Changes:
POST /api/file/:fileType/:streamId/:branchName?endpoint isapplication/jsonPOST /api/file/:fileType/:streamId/:branchName?.POST /api/file/:fileType/:streamId/:branchName?are valid jsonTo-do before merge:
Screenshots:
Validation of changes:
Checklist:
References