Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(helm chart): root is read-only so mount volume to specific directory #3458

Merged
merged 3 commits into from
Nov 7, 2024

Conversation

iainsproat
Copy link
Contributor

@iainsproat iainsproat commented Nov 7, 2024

Description & motivation

The Helm Chart attempted to mount the volume at /. Root is protected and read-only, so we must mount a volume to a sub-directory.

We can also use the path parameter of the volume, to place the secret contents at a particular path

Changes:

To-do before merge:

Screenshots:

Validation of changes:

We can see the file is mounted at the expected path, and the contents are as expected:

Screenshot 2024-11-07 at 13 04 48

Checklist:

  • My pull request follows the guidelines in the Contributing guide?
  • My pull request does not duplicate any other open Pull Requests for the same update/change?
  • My commits are related to the pull request and do not amend unrelated code or documentation.
  • My code follows a similar style to existing code.
  • I have added appropriate tests.
  • I have updated or added relevant documentation.

References

@iainsproat iainsproat marked this pull request as ready for review November 7, 2024 13:07
@iainsproat iainsproat requested a review from gjedlicska November 7, 2024 13:07
@gjedlicska gjedlicska merged commit 01450de into main Nov 7, 2024
35 of 38 checks passed
@gjedlicska gjedlicska deleted the iain/fix-helm-chart-multi-region-config-mount branch November 7, 2024 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants