Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(helm chart): include multi-region feature flag and mount volume from secret #3453

Merged
merged 4 commits into from
Nov 7, 2024

Conversation

iainsproat
Copy link
Contributor

@iainsproat iainsproat commented Nov 6, 2024

Description & motivation

The Helm chart sets the FF_WORKSPACES_MULTI_REGION_ENABLED and MULTI_REGION_CONFIG_PATH environment variables.

Where required, it mounts the multi-region-config.json file at the path given by the value of MULTI_REGION_CONFIG_PATH.

Changes:

To-do before merge:

Screenshots:

Validation of changes:

Checklist:

  • My pull request follows the guidelines in the Contributing guide?
  • My pull request does not duplicate any other open Pull Requests for the same update/change?
  • My commits are related to the pull request and do not amend unrelated code or documentation.
  • My code follows a similar style to existing code.
  • I have added appropriate tests.
  • I have updated or added relevant documentation.

References

@iainsproat iainsproat requested a review from gjedlicska November 7, 2024 00:03
@iainsproat iainsproat marked this pull request as ready for review November 7, 2024 00:03
@iainsproat iainsproat changed the title feat(helm chart): include multi-region feature flag and volume from s… feat(helm chart): include multi-region feature flag and mount volume from secret Nov 7, 2024
@iainsproat iainsproat merged commit 05ba9ee into main Nov 7, 2024
27 of 28 checks passed
@iainsproat iainsproat deleted the iain/multi-region-all-services branch November 7, 2024 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants