Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Viewer Exports Updated & Debug Normal Pass in the Sandbox #3451

Merged
merged 1 commit into from
Nov 7, 2024

Conversation

AlexandruPopovici
Copy link
Contributor

Description & motivation

Changes:

To-do before merge:

Screenshots:

Validation of changes:

Checklist:

  • My pull request follows the guidelines in the Contributing guide?
  • My pull request does not duplicate any other open Pull Requests for the same update/change?
  • My commits are related to the pull request and do not amend unrelated code or documentation.
  • My code follows a similar style to existing code.
  • I have added appropriate tests.
  • I have updated or added relevant documentation.

References

Copy link
Contributor

github-actions bot commented Nov 6, 2024

📸 Preview service has generated an image.

Copy link
Member

@JR-Morgan JR-Morgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!
I have not tested locally, but lgtm

@AlexandruPopovici AlexandruPopovici merged commit 0a6e184 into main Nov 7, 2024
27 of 29 checks passed
@AlexandruPopovici AlexandruPopovici deleted the alex/gpipeline-exports branch November 7, 2024 11:21
AlexandruPopovici added a commit that referenced this pull request Nov 8, 2024
@gjedlicska gjedlicska mentioned this pull request Nov 25, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants