Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description & motivation
The default error handler for express was not logging thrown errors. Requests which incurred internal errors had their responses logged as 500 errors without any corresponding error message or stacktrace. This made investigating errors difficult.
This PR amends the default error handler to add the error it is handling to the request context.
The request context is then used by the pino http logger and any included error is logged.
Changes:
To-do before merge:
Screenshots:
Validation of changes:
Checklist:
References