Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(helm chart): Increase max object size default to 100Mb for helm chart #2692

Merged
merged 1 commit into from
Aug 19, 2024
Merged

fix(helm chart): Increase max object size default to 100Mb for helm chart #2692

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/server/modules/core/services/objects.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -698,7 +698,7 @@ function prepInsertionObject(streamId, obj) {
const objectByteSize = estimateStringMegabyteSize(stringifiedObj)
if (objectByteSize > MAX_OBJECT_SIZE_MB) {
throw new ObjectHandlingError(
`Object too large. (${objectByteSize} MB is > than limit, ${MAX_OBJECT_SIZE_MB} MB)`
`Object too large. Object ID: ${obj.id}. (${objectByteSize} MB is > than limit, ${MAX_OBJECT_SIZE_MB} MB)`
)
}
return {
Expand Down
2 changes: 1 addition & 1 deletion utils/helm/speckle-server/values.schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1313,7 +1313,7 @@
"max_object_size_mb": {
"type": "number",
"description": "The maximum size of an individual object which can be uploaded to the server",
"default": 10
"default": 100
},
"requests": {
"type": "object",
Expand Down
2 changes: 1 addition & 1 deletion utils/helm/speckle-server/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -814,7 +814,7 @@ objects:
port: '7000'

## @param objects.max_object_size_mb The maximum size of an individual object which can be uploaded to the server
max_object_size_mb: 10
max_object_size_mb: 100

requests:
## @param objects.requests.cpu The CPU that should be available on a node when scheduling this pod.
Expand Down