Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(preview-service): allow metrics port to be configured #2421

Merged
merged 2 commits into from
Jun 21, 2024

Conversation

iainsproat
Copy link
Contributor

Description & motivation

If debugging or developing the Preview Service it is helpful to be able to assign a different port for the metrics server. This PR allows the port to be configured via the Helm Chart.

Changes:

To-do before merge:

Screenshots:

Validation of changes:

Checklist:

  • My pull request follows the guidelines in the Contributing guide?
  • My pull request does not duplicate any other open Pull Requests for the same update/change?
  • My commits are related to the pull request and do not amend unrelated code or documentation.
  • My code follows a similar style to existing code.
  • I have added appropriate tests.
  • I have updated or added relevant documentation.

References

@iainsproat iainsproat marked this pull request as ready for review June 21, 2024 14:15
@iainsproat iainsproat requested a review from gjedlicska June 21, 2024 14:15
@iainsproat iainsproat merged commit 2e59d23 into main Jun 21, 2024
24 of 25 checks passed
@iainsproat iainsproat deleted the iain/fix-preview-service-protocol-error branch June 21, 2024 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant