Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Grid/List view toggle component to make the active item clearer #2108

Merged
merged 2 commits into from
Mar 11, 2024

Conversation

benjaminvo
Copy link
Contributor

I've updated the Grid/List view toggle component to make it clearer which item is the active item. The old design made it appear as if the inactive item was the active item.

Changes

  • The active item has the light background color, some spacing around it, and a shadow.
  • Updated tippy to have one for each of the two toggle items. "Grid View" / "List View"
  • Note: I've used a few dark: Tailwind classes to tweak the colors in dark mode. I've heard from Andrew we don't want to do this but it didn't work well in dark mode without it.

Screenshots

Before

The item with the darker background below is the active item even though you'd think it's the white one.

CleanShot 2024-03-08 at 08 10 35@2x

CleanShot 2024-03-08 at 08 12 30@2x

After

CleanShot 2024-03-08 at 08 10 18@2x

CleanShot 2024-03-08 at 08 12 00@2x

Copy link
Contributor

@andrewwallacespeckle andrewwallacespeckle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huge improvement, a lot clearer now!

@benjaminvo benjaminvo merged commit 7eea29e into main Mar 11, 2024
33 of 34 checks passed
@benjaminvo benjaminvo deleted the origin/benjamin/toggle-updates branch March 11, 2024 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants