-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(fileimport-service): write valid messages from underlying parsers #1969
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add apollo query duration * feat: add more details to apollo query logging * fix: pr review
…ity (#1948) * better req log text * minor improvements to server logging * WIP FE2 req logging * FE2 apollo operation logging * undid apolloPlugin changes due to Gergos PR * seq message templates introduced
…irectly to std(out|err)
* fix: request logs * chore: remove comments
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1969 +/- ##
=======================================
Coverage 68.53% 68.53%
=======================================
Files 213 213
Lines 8107 8107
Branches 946 946
=======================================
Hits 5556 5556
Misses 2288 2288
Partials 263 263 ☔ View full report in Codecov by Sentry. |
- presuming passing of the functions was the cause
gjedlicska
previously approved these changes
Jan 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description & motivation
The file import service was not producing logs in clef format when wrapping the logs generated by underlying parsers.
This improves the handling of log messages to support CLEF.
Changes:
To-do before merge:
{message}
(see red highlight in screenshot) is being properly interpolated.Screenshots:
Validation of changes:
Checklist:
References