Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to add record set for cog children #5498

Merged
merged 1 commit into from
Dec 19, 2024
Merged

Allow to add record set for cog children #5498

merged 1 commit into from
Dec 19, 2024
+6 −0

Conversation

CarolineDenis
Copy link
Contributor

Fixes #5486

Checklist

  • Self-review the PR after opening it to make sure the changes look good and
    self-explanatory (or properly documented)
  • Add relevant issue to release milestone

Testing instructions

  • Create a new COG
  • Add children using magnifying glass then record set
  • Choose a record set
  • verify the COs or COGs from the RS have been added in the children

@CarolineDenis CarolineDenis added this to the 7.9.10 milestone Dec 19, 2024
@CarolineDenis CarolineDenis requested review from sharadsw and a team December 19, 2024 15:19
grantfitzsimmons
grantfitzsimmons approved these changes Dec 19, 2024
View reviewed changes
Copy link
Member

@grantfitzsimmons grantfitzsimmons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • verify the COs or COGs from the RS have been added in the children

👍

@CarolineDenis CarolineDenis merged commit 23b6226 into production Dec 19, 2024
12 checks passed
@CarolineDenis CarolineDenis deleted the issue-5486 branch December 19, 2024 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grantfitzsimmons grantfitzsimmons grantfitzsimmons approved these changes

@sharadsw sharadsw sharadsw approved these changes

@acwhite211 acwhite211 acwhite211 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
General Tester Board
Status: ✅Done
Milestone
7.9.10
Development

Successfully merging this pull request may close these issues.

Cannot add Record Set items to a COG
4 participants
@CarolineDenis @acwhite211 @sharadsw @grantfitzsimmons