Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support COT catalog number format configuration in WorkBench #5489

Merged
merged 5 commits into from
Dec 19, 2024

Conversation

melton-jason
Copy link
Contributor

Fixes #5473
Related to #5232

Screen.Recording.2024-12-18.at.1.18.21.PM.mov

Checklist

  • Self-review the PR after opening it to make sure the changes look good and
    self-explanatory (or properly documented)
  • Add automated tests
  • Add relevant issue to release milestone

Testing instructions

  • Create or find a CollectionObjectType with a Catalog Number Format Name which differs from that of the Collection's default Catalog Number format

    • You can run a query on the Collection table with the Catalog Num Format Name field to determine the default format
  • Create a Collection Object WorkBench data set which includes Collection Object -> catalogNumber and Collection Object -> collectionObjectType -> name

  • Consider the following possibilities for CollectionObjectType -> name (these will be used in the next step):

    • The prior Collection Object Type's name from the first type is selected
      • This corresponds to the Collection's default format
    • Any other Collection Object Type's name with a different Catalog Number Format Name is provided
    • No Collection Object Type -> name is provided
  • For each of the above CollectionObjectType configurations, have a row in the data set where:

    • The catalogNumber matches the expected format of the Collection Object Type
    • The catalogNumber does not match the expected format of the Collection Object Type
  • Validate the data set and ensure that for each row the CollectionObjectType's Catalog Number format is being properly respected

  • Remove the invalid rows and Upload the data set

  • Ensure the Collection Objects are properly uploaded and with the correct Catalog Number and Collection Object Type

  • Perform the above steps with a data set which doesn't have CollectionObject as a base table.
    For example, some tables which map to CollectionObject are:

    • Accession -> collectionObjects
    • Paleo Context -> collectionObjects
    • Collecting Event -> collectionObjects
    • Collection Relationship -> leftSide and Collection Relationship -> rightside
    • Exsiccata Item -> collectionObject

@melton-jason melton-jason added this to the 7.9.10 milestone Dec 18, 2024
@melton-jason melton-jason requested review from a team December 18, 2024 19:42
@melton-jason melton-jason changed the title Support COT catalog number format in WorkBench Support COT catalog number format configuration in WorkBench Dec 18, 2024
Copy link
Contributor

@alesan99 alesan99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing instructions

  • Validate the data set and ensure that for each row the CollectionObjectType's Catalog Number format is being properly respected

  • Ensure the Collection Objects are properly uploaded and with the correct Catalog Number and Collection Object Type

  • Perform the above steps with a data set which doesn't have CollectionObject as a base table.


Working as intended 👌
chrome_RPCoC2hPBe

Even holds up in tricky conditions!
chrome_SVgRdVwCqV

@alesan99 alesan99 requested a review from a team December 18, 2024 21:34
@CarolineDenis CarolineDenis merged commit 38949a8 into production Dec 19, 2024
12 checks passed
@CarolineDenis CarolineDenis deleted the issue-5473 branch December 19, 2024 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Support COT Catalog Numbering Configurations in the WorkBench
4 participants