Add get_spmodel_class to replace getattr for Specify models, temp solution #5354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l make better in future
| @@ -113,11 +113,23 @@ | |||
| 'Tectonicunittreedefitem': 'Tectonicunit' | |||
| } | |||
|
|
|||
| def get_spmodel_class(model_name: str): | |||
There was a problem hiding this comment.
the issue is not resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5349
Avoid problems with getattr when getting model class names from Specify models due to capitalization differences. In order to maintain python class name readability, we create a utility function that can handling getting the class by name, even if the capitalization in the names don't match.
The get_spmodel_class functions is added in each file it is needed for now in order to avoid circular imports, I will make better in future.
Checklist
and self-explanatory (or properly documented)
Testing instructions
Open schema config
Choose one of the age table relativeAge - absoluteAge - absoluteAgeCitation, ...
Open uniqueness rule tool
Click add a rule
See crash