Adjust notification timing for development mode #5090
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CarolineDenis
approved these changes
Jul 11, 2024
maxpatiiuk
approved these changes
Jul 11, 2024
There was a problem hiding this comment.
This looks good, but if you are interested in an even better solution, there are some more sophisticated web APIs we can use to make notifications fetching more efficient and to reduce the noise in the network panel. See:
#2606
(that issue is marked as fixed because a basic improvement was done, but more improvements are still possible)
specifyweb/frontend/js_src/lib/components/Notifications/hooks.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: Max Patiiuk <[email protected]>
|
@maxpatiiuk that sounds like it would be good to implement but for now putting this in as-is to make things a bit nicer will be alright. I'll look into it though! |
alesan99
approved these changes
Jul 15, 2024
grantfitzsimmons
approved these changes
Jul 15, 2024
Areyes42
approved these changes
Jul 15, 2024
|
🎉 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adjusts the interval for when notifications are fetched in development mode, to make it easier to filter through requests in the debug console while testing/debugging/etc.
I set the development time interval to 1 minute, but that can be adjusted easily if needed.
Checklist
and self-explanatory (or properly documented)
Testing instructions