-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Encode exported Query file paths #5070
base: production
Are you sure you want to change the base?
Conversation
Triggered by 23679b7 on branch refs/heads/issue-5069
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good - do we need to do this anywhere else? (i.e other notifications that have files)
@maxpatiiuk Though yes, it's probably best we eliminate this bug in the other places before it becomes a problem. I'll push a fix for those files too. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Testing instructions
- Save and export query with
#
in the query's name - Export the query as a CSV/KML (without selected any Query Results)
- Ensure the file can be downloaded and the full query name is in the downloaded file's name
- Save and export query with
?
in the query's name - Export the query as a CSV/KML (without selected any Query Results)
- Ensure the file can be downloaded and the full query name is in the downloaded file's name
For other special characters: @$%&+?\=;,"
:
- Save a Query containing one or more of the characters
- Ensure that Query export files can still be downloaded, the entire query name is present in the file name (special characters are either present in the download file name or replaced with
_
)
I tested with various special characters, and they work with both unselected and selected queries.
One thing that I noticed unrelated to this PR — creating a CSV from selected query fields doesn't trigger the same notification download behavior. Is this expected?
Screen.Recording.2024-07-08.at.11.59.25.AM.mp4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Testing instructions
- Save and export query with
#
in the query's name - Export the query as a CSV/KML (without selected any Query Results)
- Ensure the file can be downloaded and the full query name is in the downloaded file's name
- Save and export query with
?
in the query's name - Export the query as a CSV/KML (without selected any Query Results)
- Ensure the file can be downloaded and the full query name is in the downloaded file's name
For other special characters: @$%&+?\=;,"
:
- Save a Query containing one or more of the characters
- Ensure that Query export files can still be downloaded, the entire query name is present in the file name (special characters are either present in the download file name or replaced with
_
)
Looks good! The file names are exported correctly.
Fixes #5069
Note:
The Export process still completely fails if the Query name contains
/
(the character is interpreted as part of the file path).Checklist
and self-explanatory (or properly documented)
Testing instructions
#
in the query's name?
in the query's nameFor other special characters:
@$%&+?\=;,"
:_
)