Merge pull request #4777 from specify/wb-disambiguate-all-fix

Fix disambiguate all incorrectly affectly records
specify · Apr 26, 2024 · 0cfa2ec · 0cfa2ec
2 parents 275e448 + 704448b
commit 0cfa2ec
Showing 1 changed file with 6 additions and 6 deletions.
diff --git a/specifyweb/frontend/js_src/lib/components/WorkBench/DisambiguationLogic.tsx b/specifyweb/frontend/js_src/lib/components/WorkBench/DisambiguationLogic.tsx
@@ -199,21 +199,21 @@ export class Disambiguation {
                 visualRow--
               ) {
                 const physicalRow = this.wbView.hot!.toPhysicalRow(visualRow);
-                if (
-                  !this.wbView.validation.uploadResults.ambiguousMatches[
+                const ambiguousMatchToDisambiguate =
+                  this.wbView.validation.uploadResults.ambiguousMatches[
                     physicalRow
                   ]?.find(
                     ({ key, mappingPath }) =>
                       key === matches.key &&
                       typeof this.getDisambiguation(physicalRow)[
                         mappingPathToString(mappingPath)
                       ] !== 'number'
-                  )
-                )
-                  continue;
+                  );
+
+                if (ambiguousMatchToDisambiguate === undefined) continue;
                 this.setDisambiguation(
                   physicalRow,
-                  matches.mappingPath,
+                  ambiguousMatchToDisambiguate.mappingPath,
                   selected.id
                 );
                 this.wbView.validation.startValidateRow(physicalRow);