Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core/xref): improve errors, show for context #3656

Merged
merged 5 commits into from
Jun 29, 2021
Merged

fix(core/xref): improve errors, show for context #3656

merged 5 commits into from
Jun 29, 2021

Conversation

marcoscaceres
Copy link
Contributor

@marcoscaceres marcoscaceres commented Jun 28, 2021 •
edited
Loading

Closes #3642

sidvishnoi
sidvishnoi approved these changes Jun 28, 2021
View reviewed changes
Copy link
Member

@sidvishnoi sidvishnoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Few nits..

src/core/xref.js Outdated Show resolved Hide resolved
src/core/xref.js Outdated Show resolved Hide resolved
src/core/xref.js Outdated Show resolved Hide resolved
@sidvishnoi sidvishnoi changed the title fix(core/xref): improve errors + show for= context fix(core/xref): improve errors, show for context Jun 28, 2021
@marcoscaceres marcoscaceres merged commit 68fb2de into develop Jun 29, 2021
@marcoscaceres marcoscaceres deleted the error_for branch June 29, 2021 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sidvishnoi sidvishnoi sidvishnoi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing "for" in error messages
2 participants
@marcoscaceres @sidvishnoi