Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: no longer build jQuery dependency #3023

Merged
merged 1 commit into from
Jul 17, 2020
Merged

chore: no longer build jQuery dependency #3023

merged 1 commit into from
Jul 17, 2020

Conversation

sidvishnoi
Copy link
Member

@sidvishnoi sidvishnoi commented Jul 16, 2020 •
edited
Loading

Part of https://github.com/w3c/respec/issues/2889

  • Well, one less dependency build.
  • Keeping the jQuery in package.json only to keep w3c-common branch in sync, so we don't need to npm install when switching branch locally. Also helps in using same CI cache 😄. Can remove if you prefer.

@sidvishnoi sidvishnoi mentioned this pull request Jul 16, 2020
Open
9 tasks
@sidvishnoi sidvishnoi requested a review from saschanaz July 16, 2020 21:37
@sidvishnoi
Copy link
Member Author

Bonus: It reduced build time in GitHub Action and Netlify build by 1 second 😄 :shipit:

@saschanaz
Copy link
Collaborator

I'm okay with it. Sad that we can't have a comment in package.json, though.

@sidvishnoi sidvishnoi merged commit af9b309 into develop Jul 17, 2020
@sidvishnoi sidvishnoi deleted the no-jquery-dep-build branch July 17, 2020 05:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saschanaz saschanaz saschanaz approved these changes

@marcoscaceres marcoscaceres marcoscaceres approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sidvishnoi @saschanaz @marcoscaceres