Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core/dfn-finder): explicit empty dfn-for on top level things #2558

Merged
merged 3 commits into from
Nov 5, 2019
Merged

fix(core/dfn-finder): explicit empty dfn-for on top level things #2558

merged 3 commits into from
Nov 5, 2019

Conversation

sidvishnoi
Copy link
Member

@marcoscaceres
Copy link
Contributor

I think we want to test a couple of top-level things... might be quick just to dig into the IDL tests and find a:

  • dictionary
  • enum
  • interface

And make sure that attribute and methods are still for things.

marcoscaceres
marcoscaceres approved these changes Nov 4, 2019
View reviewed changes
Copy link
Contributor

@marcoscaceres marcoscaceres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the tests.

@marcoscaceres marcoscaceres merged commit 124d75d into develop Nov 5, 2019
@marcoscaceres marcoscaceres deleted the top-level-dfn-for branch November 5, 2019 06:35
marcoscaceres added a commit that referenced this pull request Nov 20, 2019
@marcoscaceres
Merge branch 'develop' into gh-pages
19f6dae 
* develop:
  v24.34.2
  fix(tools/release): components no longer built
  chore: don't update deps
  chore(package): npm audit fixes
  Update eslint-plugin-jasmine to the latest version 🚀 (#2571)
  chore(package): update eslint-plugin-jasmine to version 3.0.0
  chore(package): update deps (#2562)
  fix(core/dfn-finder): explicit empty dfn-for on top level things (#2558)
  refactor: migrate to pure es modules (#2553)
  fix(tools/copydeps): gracely ignore when no folder (#2556)
  refactor: force extensions for imports (#2555)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcoscaceres marcoscaceres marcoscaceres approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Top level IDL things should have data-dfn-for=""
3 participants
@sidvishnoi @marcoscaceres @saschanaz