Track message output as part of the testsuite #2635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g enough that I *should* be able to infer it.
…messages. Check messages for the normal run.
…oses an unstable memory address.
…t exposes an (unstable across machines) local path.
…her, because it includes a (machine-specific) path.
tabatkins
force-pushed
the
log-test-messages
branch
from
e7a4ba3
to
917271d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change, Bikeshed now tracks both the built spec (as a
.htmlfile) and the message output from building the spec (as a.console.txtfile) in the testsuite. This finally gives me visibility into error-message changes, which can be build-breakers even if the resulting spec didn't change at all.(/cc @domenic who's been asking for this for a while)
No behavior changes overall; the only changes outside of the testing functionality was adding a few sorts to some message outputs to ensure the messages are stable.
As part of this I also fiddle with the
bikeshed testinvocation syntax; the glob args were really annoying in practice, so I ripped them out in favor of a--fileoption. I'll probably tweak this more as I go.