Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add oas3 examples #622

Merged
merged 1 commit into from
Sep 13, 2018
Merged

add oas3 examples #622

merged 1 commit into from
Sep 13, 2018

Conversation

dtkav
Copy link
Collaborator

@dtkav dtkav commented Jul 11, 2018

Relates to #420
Split out examples from #621 to make code review easier.

Changes proposed in this pull request:

  • move existing examples under examples/swagger2
  • add more examples under examples/openapi

@coveralls
Copy link

coveralls commented Jul 11, 2018

Coverage Status

Coverage remained the same at 99.553% when pulling f950ca6 on dtkav:oas3_examples into eb374a6 on zalando:dev-2.0.

@hjacobs
Copy link
Contributor

hjacobs commented Jul 11, 2018

Thanks!

@Ryan-Gordon
Copy link

Hey @dtkav , went to check out your PR as I was thinking of updating some of the examples to OAS3 also but found yours, when I try to run the projects I get this error :
swagger_spec_validator.common.SwaggerValidationError: 'swagger' is a required property
If the connexion library isn't fully ready for OAS3 that may be why but could you confirm if these run on your local machine ?

@dtkav
Copy link
Collaborator Author

dtkav commented Jul 16, 2018

hey @Ryan-Gordon - this PR was split out from #621 (add oas3 support) in order to make that PR smaller and more reviewable. We are working towards a 2.0 release of Connexion (that will include OpenAPI3 support) on the dev-2.0 branch. The idea is that we'll merge some backwards-incompatible changes, improvements, oas3 support, and then these examples.

@Ryan-Gordon
Copy link

Hey @dtkav,
Just checked out that other PR and can see quite a bit of work there so its all making alot more sense now. Thank you for clarifying !

@rafaelcaricio rafaelcaricio self-assigned this Jul 23, 2018
@dtkav dtkav mentioned this pull request Aug 10, 2018
@dtkav dtkav force-pushed the dev-2.0 branch 2 times, most recently from 0621fb8 to 99ac95f Compare August 24, 2018 03:57
@dtkav dtkav force-pushed the oas3_examples branch 3 times, most recently from 9a50e5f to 073a314 Compare September 12, 2018 01:19
@dtkav dtkav changed the title WIP: add oas3 examples add oas3 examples Sep 12, 2018
@JuxhinDB
Copy link

Wonderful work, loved the examples!

@dtkav
Copy link
Collaborator Author

dtkav commented Sep 13, 2018

Thanks @JuxhinDB

@dtkav dtkav merged commit d093225 into spec-first:dev-2.0 Sep 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants