Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move from caret to inequality requirements #1704

Merged
merged 3 commits into from
May 9, 2023

Conversation

marcin-lulek-cint
Copy link
Contributor

Fixes # .
I want to use connexion with newer Starlette

Changes proposed in this pull request:

  • Loosen requirements on starlette version

@RobbeSneyders
Copy link
Member

Thanks @marcin-lulek-cint!

The Poetry packaging doesn't work as I expected. It's recommended that we switch to inequality versioning instead of caret versioning.

I added a commit to change this for all dependencies.

@RobbeSneyders
Copy link
Member

I had to revert the python version to caret notation since installing otherwise fails because py-swagger-ui does define an upper bound for the python version via caret notation. We'll have to update it there first.

@RobbeSneyders RobbeSneyders changed the title Starlette had new releases. Move from caret to inequality requirements May 4, 2023
@RobbeSneyders RobbeSneyders requested a review from Ruwann May 4, 2023 21:24
@coveralls
Copy link

Coverage Status

Coverage: 94.042%. Remained the same when pulling 37f9e87 on marcin-lulek-cint:patch-1 into 15fe2ed on spec-first:main.

Copy link
Member

@Ruwann Ruwann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM!

@Ruwann Ruwann merged commit fc1f0df into spec-first:main May 9, 2023
@marcin-lulek-cint
Copy link
Contributor Author

While I'm a Poetry fan - I think it works best for applications - not upstream packages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants