Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Example for rdfReader #17

Merged
merged 2 commits into from
Aug 24, 2019
Merged

Conversation

abhishekspeer
Copy link
Contributor

Signed-off-by: [email protected]

Added example to test RDF reader.

@abhishekspeer abhishekspeer force-pushed the exampleLoader branch 2 times, most recently from 893b574 to ebaaac2 Compare August 17, 2019 17:46
@abhishekspeer
Copy link
Contributor Author

@swinslow and @rtgdk, I've added example script to use rdf loader via this PR. Please suggest changes if any. :)

Signed-off-by: abhishekspeer <[email protected]>
@swinslow
Copy link
Member

Looks good! Two comments:

  • I see that this is missing the SPDX license statement at the top of the file, but I saw also that you added that in 058a618 (Add rdfSaver Files #14) so no need to add it in this current PR.
  • I think this is demonstrating some problems with the parsing. E.g., when I run it against the example RDF file you included, I see that it is printing two package names but both are named glibc. It appears that one of them should be named Saxon based on the sample file.

For the second point, see

<spdx:name>Saxon</spdx:name>

This is something we should address but I am guessing it is a problem with the rdfloader code, not in this example file. So I will go ahead and merge this PR.

@swinslow swinslow merged commit 01d9554 into spdx:rdfreader Aug 24, 2019
@swinslow swinslow added this to the 0.1.0 milestone Jul 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants