Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for inter-dependent maven modules forcing build. #160

Merged
merged 1 commit into from
Mar 11, 2024

Conversation

vajain-1982
Copy link

Fix for issue #158 .
In case of multi module inter dependent repo , pre-plugin step fails to resolve dependencies in case one module has dependency on other jars ( which will not be available until a complete build happens).
With this fix pre-plugin dependency will not fail for inter-dependent module jars.

@goneall
Copy link
Member

goneall commented Mar 10, 2024

Thanks @vajain-1982 for contributing the fix!

@manojbsw - can you verify this works for your case?

@manojbsw
Copy link

Thanks @vajain-1982 for contributing the fix!

@manojbsw - can you verify this works for your case?

Yes this will work. Thanks @vajain-1982 and @goneall

@goneall
Copy link
Member

goneall commented Mar 11, 2024

Merging this in - let me know if we should spin another release soon to include this fix

@goneall goneall merged commit b725783 into spdx:master Mar 11, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants