Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add /Core/Individuals/SpdxOrganization #880

Merged
merged 5 commits into from
Sep 13, 2024
Merged

Conversation

bact
Copy link
Collaborator

@bact bact commented Sep 11, 2024

Signed-off-by: Arthit Suriyawongkul <[email protected]>
@bact bact added this to the 3.0.1 milestone Sep 11, 2024
@bact bact added Profile:Core publishing Dependency for publishing final version of spec labels Sep 11, 2024
@bact bact self-assigned this Sep 11, 2024
model/Core/Individuals/SpdxOrganization.md Outdated Show resolved Hide resolved
model/Core/Individuals/SpdxOrganization.md Outdated Show resolved Hide resolved
model/Core/Individuals/SpdxOrganization.md Outdated Show resolved Hide resolved
bact and others added 4 commits September 12, 2024 08:25
Co-authored-by: Alexios Zavras (zvr) <[email protected]>
Signed-off-by: Arthit Suriyawongkul <[email protected]>
Co-authored-by: Alexios Zavras (zvr) <[email protected]>
Signed-off-by: Arthit Suriyawongkul <[email protected]>
Co-authored-by: Alexios Zavras (zvr) <[email protected]>
Signed-off-by: Arthit Suriyawongkul <[email protected]>
Signed-off-by: Arthit Suriyawongkul <[email protected]>
@bact bact requested a review from zvr September 12, 2024 07:29
@bact
Copy link
Collaborator Author

bact commented Sep 12, 2024

Thank you @zvr for the review. All suggestions merged.

@bobmartin3000 please be aware of this addition to the model.
It is a necessary one to make the whole model conform with the spec.

@goneall
Copy link
Member

goneall commented Sep 12, 2024

I wonder if we should make the IRI more specific - for example, https://spdx.org/organization

I could create a web page with a redirect to https://spdx.dev/about/overview/

@zvr
Copy link
Member

zvr commented Sep 12, 2024

I am confused... Don't you think that "https://spdx.org" is the right identifier for the SPDX project?

I mean, for another example, Intel has tons of pages describing the company (equivalent to "About us"), but the identifier to be used in such a context will definitely be https://www.intel.com/.

It will also be useful to others who would want to refer to the SPDX project to be able to simply use <https://spdx.org> as an Element identifier.

Copy link
Member

@goneall goneall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@goneall
Copy link
Member

goneall commented Sep 13, 2024

I am confused... Don't you think that "https://spdx.org" is the right identifier for the SPDX project?

I mean, for another example, Intel has tons of pages describing the company (equivalent to "About us"), but the identifier to be used in such a context will definitely be https://www.intel.com/.

It will also be useful to others who would want to refer to the SPDX project to be able to simply use <https://spdx.org> as an Element identifier.

My suggest is based on "https://spdx.org" being the prefix for the SPDX RDF ontology which may be somewhat confusing.

That said, I'm OK going with the proposed URI.

I've approved the PR - so feel free to merge if you'd like to go with the current URI.

@bact
Copy link
Collaborator Author

bact commented Sep 13, 2024

My suggest is based on "https://spdx.org" being the prefix for the SPDX RDF ontology which may be somewhat confusing.

Got it.

I think in that case, we can say

@zvr zvr merged commit 0e8690a into spdx:main Sep 13, 2024
1 check passed
@bact bact deleted the add-SpdxOrganization branch September 13, 2024 10:33
@bact
Copy link
Collaborator Author

bact commented Sep 13, 2024

SpdxOrganization spec is now available at
https://spdx.github.io/spdx-spec/v3.0.1/model/Core/Individuals/SpdxOrganization/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Profile:Core publishing Dependency for publishing final version of spec
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants