-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add /Core/Individuals/SpdxOrganization #880
Conversation
Signed-off-by: Arthit Suriyawongkul <[email protected]>
Co-authored-by: Alexios Zavras (zvr) <[email protected]> Signed-off-by: Arthit Suriyawongkul <[email protected]>
Co-authored-by: Alexios Zavras (zvr) <[email protected]> Signed-off-by: Arthit Suriyawongkul <[email protected]>
Co-authored-by: Alexios Zavras (zvr) <[email protected]> Signed-off-by: Arthit Suriyawongkul <[email protected]>
Signed-off-by: Arthit Suriyawongkul <[email protected]>
Thank you @zvr for the review. All suggestions merged. @bobmartin3000 please be aware of this addition to the model. |
I wonder if we should make the IRI more specific - for example, I could create a web page with a redirect to https://spdx.dev/about/overview/ |
I am confused... Don't you think that "https://spdx.org" is the right identifier for the SPDX project? I mean, for another example, Intel has tons of pages describing the company (equivalent to "About us"), but the identifier to be used in such a context will definitely be https://www.intel.com/. It will also be useful to others who would want to refer to the SPDX project to be able to simply use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
My suggest is based on "https://spdx.org" being the prefix for the SPDX RDF ontology which may be somewhat confusing. That said, I'm OK going with the proposed URI. I've approved the PR - so feel free to merge if you'd like to go with the current URI. |
Got it. I think in that case, we can say
|
|
SpdxOrganization
Note that currently "## Property Values" is not processed, another PR in spec-parser is needed for spdxId, etc to be included in SpdxOrganization - see: Process "Property values" for named individuals spec-parser#155