Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify ExternalIdentifier and ExternalRef #710

Merged
merged 1 commit into from
Apr 12, 2024

Conversation

rnjudge
Copy link
Collaborator

@rnjudge rnjudge commented Apr 10, 2024

This commit attempts to clarify the differences between ExternalIdentifier and ExternalRef classes.

Closes #705

Copy link
Contributor

@kestewart kestewart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spotted a minor type that should be fixed (see suggestion that can be applied). But after that LGTM and helps improve the clarity.

model/Core/Classes/ExternalIdentifier.md Outdated Show resolved Hide resolved
@kestewart kestewart added this to the 3.0 milestone Apr 11, 2024
This commit attempts to clarify the differences between
ExternalIdentifier and ExternalRef classes.

Closes spdx#705

Signed-off-by: Rose Judge <[email protected]>
@kestewart kestewart merged commit 9917fed into spdx:main Apr 12, 2024
1 check passed
Copy link
Member

@goneall goneall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clarify description between ExternalIdentifier and ExternalReference
4 participants