Change isDirectory to fileKind enumeration #666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zvr
requested changes
Mar 12, 2024
kestewart
requested changes
Mar 19, 2024
|
|
||
| ## Description | ||
|
|
||
| An SPDX file may represent a file on disk or a directory of files. In the future, this may be extended to other kinds (e.g. network based files). |
There was a problem hiding this comment.
file could be in memory not just "disk".... probably want to rephrase to something like:
"represent a file on disk" to "represent a specific file"
Fixes #630 Note that fileKind was choosen since fileType is already in use Signed-off-by: Gary O'Neall <[email protected]>
Signed-off-by: Gary O'Neall <[email protected]>
Signed-off-by: Gary O'Neall <[email protected]>
|
@zvr @kestewart - updated per comments - please review or request changes |
zvr
approved these changes
Mar 22, 2024
kestewart
approved these changes
Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #630
Note that fileKind was choosen since fileType is already in use