Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

markup change to MIT-Khronos-old #2496

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

markup change to MIT-Khronos-old #2496

wants to merge 1 commit into from

Conversation

xsuchy
Copy link
Collaborator

@xsuchy xsuchy commented Jun 10, 2024

In the review in #2017 it was said that this paragraph: This text may be omittable (B.3.5 Guideline: omittable text), as it is merely informative or explanatory, not any right grant or restriction.

but the optional tags were not added in the initial commit. Adding now.

In the review in spdx#2017 it was said that this paragraph:
This text may be omittable (B.3.5 Guideline: omittable text), as it is merely informative or explanatory, not any right grant or restriction.

but the optional tags were not added in the initial commit. Adding now.
@swinslow
Copy link
Member

Hi @xsuchy, thanks for this.

I'm not sure I agree with that conclusion from the reviewer of the issue originally. I think they were proposing to make that optional in the course of deciding whether it could be considered a match for standard MIT (which we decided it wasn't, hence the new ID).

If we make that paragraph optional, then I think the only differences between this and the standard MIT license would be using "Materials" instead of "Software as the defined term; and an "and/or" instead of "and" in the first sentence.

Just to ask, though, are you seeing any instances of the MIT-Khronos-old text appearing without that central paragraph? Put another way, are there examples you're encountering where making this paragraph optional would cause it to match a license text you've seen?

@xsuchy
Copy link
Collaborator Author

xsuchy commented Aug 16, 2024

Just to ask, though, are you seeing any instances of the MIT-Khronos-old text appearing without that central paragraph?

Yes.
https://sourceforge.net/p/mingw-w64/mingw-w64/ci/master/tree/mingw-w64-headers/include/GL/glext.h

@swinslow
Copy link
Member

Got it, thanks @xsuchy!

@jlovejoy So this is a tricky one. It is either (1) very close to standard MIT, except with "Materials" instead of "Software" and a couple of other very minor changes:

image

...or (2) very close to MIT-Khronos-old, but without the central paragraph:

image

Do you have a preference for how to handle this? I'd lean towards minor markup to MIT as I think that's substantively closer rather than making the central paragraph optional for the Khronos variant, but I could be persuaded either way.

@swinslow swinslow added this to the 3.26.0 milestone Aug 19, 2024
@xsuchy
Copy link
Collaborator Author

xsuchy commented Oct 16, 2024

Gentle ping @jlovejoy

@pombredanne
Copy link
Member

FWIW, we have tracked this MIT variant without the extra paragraph as a separate license for about 10 years: https://github.com/aboutcode-org/scancode-toolkit/blob/develop/src/licensedcode/data/licenses/khronos.LICENSE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants