Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LGPL-2.x(-*) templates are missing a line of text compared to the GNU-published texts, causing matching to fail #2430

Closed
pmonks opened this issue Mar 26, 2024 · 5 comments
Assignees
Labels
minor updates to file URL update, notes update, etc.
Milestone

Comments

@pmonks
Copy link
Contributor

pmonks commented Mar 26, 2024

The LGPL-2.0 license text published by GNU has, at line 102, this text:

GNU LIBRARY GENERAL PUBLIC LICENSE

Similarly, the LGPL-2.1 license text published by GNU also has the same line of text, at line 115.

The associated SPDX templates are all missing this text, so matching against the GNU-published texts fails:

@karsten-klein
Copy link

karsten-klein commented Mar 30, 2024

... with respect to the LGPL-2.0 license text...

{metæffekt} Universe
canonical name: GNU Library General Public License 2.0
short name: LGPL-2.0
markers: Incompatible with Secondary License Marker, No Warranty Marker, Patent Information Marker
category: LGPL
SPDX reference id: LGPL-2.0-only
ScanCode reference id: lgpl-2.0
OSI status: approved
Open CoDE status: approved
Open CoDE approved license id: LGPL-2.0-only (SPDX)

ScanCode
matched id: lgpl-2.0

@jlovejoy jlovejoy added the minor updates to file URL update, notes update, etc. label Apr 4, 2024
@jlovejoy jlovejoy added this to the 3.24 milestone Apr 4, 2024
@pmonks
Copy link
Contributor Author

pmonks commented Apr 8, 2024

@xsuchy yes this is a subsequent instance of the license's name, much further down in the license text. If you follow the links I provided above you'll be jumped down into the template where the name should be (but currently isn't).

I wasn't able to hyperlink to the precise line number in the 3rd party license texts themselves, hence the explicit mentions of lines 102 (LPGL-2.0) & 115 (LGPL-2.1).

@xsuchy
Copy link
Collaborator

xsuchy commented Apr 8, 2024

Aha.
+1 to add it.

pmonks added a commit to pmonks/license-list-XML that referenced this issue Apr 9, 2024
jlovejoy added a commit that referenced this issue May 10, 2024
@jlovejoy
Copy link
Member

fixed by #2440

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor updates to file URL update, notes update, etc.
Projects
None yet
Development

No branches or pull requests

4 participants