Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unused imports backport #1808

Closed
wants to merge 2 commits into from
Closed

Unused imports backport #1808

wants to merge 2 commits into from

Conversation

romanc
Copy link
Contributor

@romanc romanc commented Dec 3, 2024

Backport of #1803 to v1/maintenance.

/cc @phschaad as discussed

@romanc romanc changed the title Romanc/unused imports backport Unused imports backport Dec 3, 2024
phschaad
phschaad approved these changes Dec 3, 2024
View reviewed changes
Copy link
Collaborator

@phschaad phschaad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tbennun tbennun enabled auto-merge December 5, 2024 21:21
@phschaad phschaad disabled auto-merge December 6, 2024 08:30
phschaad added a commit that referenced this pull request Dec 6, 2024
@phschaad
Import changes made in #1808
29f5c22 
Author: @romanc
@phschaad phschaad mentioned this pull request Dec 6, 2024
Merged
@phschaad
Copy link
Collaborator

phschaad commented Dec 6, 2024

#1816 takes care of this

@phschaad phschaad closed this Dec 6, 2024
@romanc romanc deleted the romanc/unused-imports-backport branch December 6, 2024 17:36
github-merge-queue bot pushed a commit that referenced this pull request Dec 7, 2024
@phschaad
Unused imports backport (successor to #1808) (#1816)
3466973 
Author: @romanc

@romanc is on leave for the next few days, thus I have replayed the
changes made in #1808 here for faster
turnaround.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phschaad phschaad phschaad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@romanc @phschaad