Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing slash in fpga codegen #175

Merged
merged 4 commits into from
Mar 24, 2020
Merged

Conversation

manuelburger
Copy link
Contributor

@manuelburger manuelburger commented Mar 22, 2020

While compiling and running on Xilinx FPGA I ran into the following issue:

terminate called after throwing an instance of 'hlslib::ocl::ConfigurationError'
  what():  Failed to open program file "/home/burgerm/thesis_dace/tasks/blas/level1/axpy/.dacecache/saxpy_perf/buildsaxpy_perf_hw.xclbin".

There is a / missing between ...build and $PROGRAM_NAME .The small change should fix it.

@tbennun tbennun requested a review from definelicht March 22, 2020 16:21
@codecov
Copy link

codecov bot commented Mar 22, 2020

Codecov Report

Merging #175 into master will decrease coverage by 0.50%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #175      +/-   ##
==========================================
- Coverage   76.93%   76.43%   -0.50%     
==========================================
  Files         112      112              
  Lines       24347    24347              
==========================================
- Hits        18731    18609     -122     
- Misses       5616     5738     +122     
Impacted Files Coverage Δ
dace/codegen/targets/xilinx.py 92.06% <100.00%> (ø)
dace/transformation/dataflow/copy_to_device.py 26.80% <0.00%> (-67.01%) ⬇️
...ce/transformation/interstate/gpu_transform_sdfg.py 77.25% <0.00%> (-12.57%) ⬇️
dace/transformation/dataflow/map_fission.py 89.71% <0.00%> (-1.65%) ⬇️
dace/transformation/dataflow/merge_arrays.py 95.08% <0.00%> (-1.64%) ⬇️
dace/codegen/targets/cpu.py 86.84% <0.00%> (-1.63%) ⬇️
dace/subsets.py 83.26% <0.00%> (-1.38%) ⬇️
dace/data.py 68.45% <0.00%> (-0.95%) ⬇️
dace/codegen/targets/cuda.py 84.38% <0.00%> (-0.84%) ⬇️
...sformation/dataflow/gpu_transform_local_storage.py 85.37% <0.00%> (-0.30%) ⬇️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 57d3640...04fa088. Read the comment docs.

@definelicht
Copy link
Contributor

@manuelburger I see Tiziano did this fix for Intel also, we just didn't carry it over to Xilinx. Could you put the slash inside the string please, then I'll approve:

kernel_file_name = "DACE_BINARY_DIR \"/{}".format(self._program_name)

… into fpga_codegen_fix

    # Please enter a commit message to explain why this merge is necessary,
@tbennun tbennun merged commit 73eedee into spcl:master Mar 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants