Fixed PruneConnectors
#1660
Merged
Fixed PruneConnectors
#1660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ions. The most important fix is that the `can_be_applied()` function checked the symbol usage while the `apply()` function did not do that. Furthermore I made some small improvements here and there and also noted down a strange behaviour about the `used_symbols()` fucntion.
…` transformation. This feature does not belong into it. Further, the implementation is a bit strange, as itz just remove some containers with name. I mean there must be no name identity between the container on the inside and the outside.
This transformation was nowhere used and it's description is just the same from `PruneSymbols`.
After a discussion with Alex Nik, I removed the check for symbols. This is because it is impossible (validation of nested SDFGs) to pass them through connectors. Instead symbol_mapping should be used, thus we do not have to check for them. An SDFG that does this is invalid anyway.
…t is maintained and when not. However, this has some consequences. I added a test, that shows that this leads, depending on the memlet configuration to different outcome of the transformation. Okay, it is only affects if the transformation can be applied or not, but still. This is also in line with my [issue#1643](spcl#1643) that shows that this is a problem.
alexnick83
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a bug in the
PruneConnectorstransformation, the apply function did not prune the sets correctly.I also made some additional changes.