Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scalar return values are now invalid #1609

Merged
merged 3 commits into from
Jul 3, 2024

Conversation

philip-paul-mueller
Copy link
Collaborator

Due to how the code generator works a scalar return value is not possible and it does not generate an error.
Returning a scalar is a desired feature as there is code in CompiledSDFG for that, but it does not work.
The frontend works around this by simply promoting everything to an one dimensional array.

This commit introduces:

  • A change to validate to reject such SDFGs.
  • A test that can test the feature, but is disabled, since it does not work.
  • A test for the new restriction.

@alexnick83 alexnick83 added this pull request to the merge queue Jul 3, 2024
Merged via the queue into spcl:master with commit e3d980a Jul 3, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants