Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include tasklet contents in graph search #145

Merged
merged 3 commits into from
May 8, 2024
Merged

Include tasklet contents in graph search #145

merged 3 commits into from
May 8, 2024

Conversation

tbennun
Copy link
Contributor

@tbennun tbennun commented May 8, 2024

No description provided.

@tbennun tbennun requested a review from phschaad May 8, 2024 17:48
public text_for_find(): string {
// Include code when searching
const code = this.attributes().code.string_data;
return this.label() + " " + code;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

space is probably not necessary

Copy link
Collaborator

@phschaad phschaad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please increment the version (patch nr.) by one before merging. It is not yet done automatically by the CI, haven't figured that out yet.

@tbennun tbennun merged commit 8a5d446 into master May 8, 2024
2 checks passed
tbennun added a commit that referenced this pull request May 8, 2024
@tbennun tbennun deleted the tbennun-patch-1 branch May 8, 2024 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants