Temporarily remove PHPStan extensions that do not support PHPStan 2.0 #428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hopefully, I'll be able to bring them back rather sooner! I have also deleted `phpstan-latte-templates (8.3)` from main branch rulesets in GitHub, which should be added back eventually.
Not needed when the two PHPStan extensions have been removed now. Originally added in #296 Also removed `check-application-mapping (8.3)` check from the main branch rulesets.
spaze
force-pushed
the
spaze/temp-remove-phpstan-extensions
branch
from
8180161 to
aea3c4f
Compare
spaze
added a commit
that referenced
this pull request
Dec 24, 2024
spaze
added a commit
that referenced
this pull request
Dec 24, 2024
The tests have been disabled in #428.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
phpstan-latte-templates.neonconfig andphp-latte.ymlworkflow)phpstan.neonconfig)Hopefully, I'll be able to bring them back rather sooner!
Deleted
check-application-mappingscript and related files too, originally added in #296, should also be added back when possible.I have also deleted the following checks from main branch rulesets in GitHub, which should be added back eventually:
phpstan-latte-templates (8.3)check-application-mapping (8.3)Follow-ups:
excludePathsthat doesn't exist anymore #430