Psalm detect unused code #207

spaze · 2023-08-23T02:58:02Z

Follow-up to #205 but now with enabled dead code detection, making it undead.

Blockers:

Analyzing a namespaced shell script with exit() gives UnevaluatedCode vimeo/psalm#10143 prevents analyzing scripts in bin/

Remove unused getLogged().

…usedFunctionCall

By either setting it to null making it exist, or by removing it making it not exist.

"Properties used in constructor only are considered unused. Use normal variables instead." https://psalm.dev/docs/running_psalm/issues/UnusedProperty/

Correct.

…hods

…ing it

If some are not it doesn't really hurt to still have them available.

Replaced by a constructor property in commit 568a25d

The method stopped being used in 98f0dbe, it was used in TemplateFactory.php::createTemplate() but Latte\Engine::addFilterLoader() using it stopped being used.

…xisting ones

spaze added 10 commits August 22, 2023 23:46

Convert the config file to use tabs

3188627

Enable unused code detection

3b5b700

Find more files as some methods are used in tests or in public

a491cdb

Suppress errors about unused classes/methods for things used by Nette

f2b8d15

Ignore errors about unused data provider methods

18d470c

Simplify test logging, always all log lines are checked

bdf1fca

Remove unused getLogged().

Call NullLogger::reset() to make sure there's nothing logged

017cb56

Also add types to function signature while we're at it

5c8f087

Remove UnusedForeachValue

aca139e

Remove PossiblyUnusedParam-s

bb288d8

spaze self-assigned this Aug 23, 2023

spaze added 15 commits August 23, 2023 17:38

Check the return value from stream_context_set_params() to resolve Un…

6bd6d96

…usedFunctionCall

Fix UnusedVariable ... is never referenced or the value is not used

4b3a58c

By either setting it to null making it exist, or by removing it making it not exist.

Resolve UnusedProperty

9c821d0

"Properties used in constructor only are considered unused. Use normal variables instead." https://psalm.dev/docs/running_psalm/issues/UnusedProperty/

The return value for this private method is never used

90be61f

Correct.

Rename methods to is* so they can be ignored with the rest of is* met…

2e18680

…hods

Drop unused properties and rename the one to something better describ…

aa863cf

…ing it

get*() and is*() are mostly used in Latte templates

e8686c5

If some are not it doesn't really hurt to still have them available.

Remove an actually unused method

77416e2

Replaced by a constructor property in commit 568a25d

This method is also unused and easy to add back if needed

a78e97e

Drop loader()

0cf55e1

The method stopped being used in 98f0dbe, it was used in TemplateFactory.php::createTemplate() but Latte\Engine::addFilterLoader() using it stopped being used.

Ignore methods that are indeed unused but let's keep them just in case

e9aecb2

Ignore PossiblyUnusedProperty, most of those are used in templates

4a5e877

Ignore PossiblyUnusedReturnValue to keep all methods similar to the e…

2b87bfd

…xisting ones

Let me know if there's an unused UnusedSomething suppression

5d4c90d

Ignore template-related seemingly unused methods & return values

226cd49

spaze force-pushed the spaze/psalm-unused-code branch from 6656d45 to 226cd49 Compare August 23, 2023 15:53

spaze merged commit e5ec908 into main Aug 23, 2023

spaze deleted the spaze/psalm-unused-code branch August 23, 2023 15:59

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Psalm detect unused code #207

Psalm detect unused code #207

spaze commented Aug 23, 2023 •

edited

Loading

Psalm detect unused code #207

Psalm detect unused code #207

Conversation

spaze commented Aug 23, 2023 • edited Loading

spaze commented Aug 23, 2023 •

edited

Loading