ARES test fails #242
Assignees
Comments
spaze
added a commit
that referenced
this issue
Oct 16, 2023
… returned as "1", yes a string, instead of "cz", so let's deal with that It could be easily removed in the future, and there's a test for it (the one for the company with id 00256081), so if it is removed and it shouldn't be, I should know about it rather soon. Fix #242
This was referenced Oct 16, 2023
Merged
spaze
added a commit
that referenced
this issue
Oct 16, 2023
I don't understand why but for this 'res' source, the country code is returned as "1", yes a string, instead of "cz", so let's deal with that. This wasn't happening when I've build the support in #225. It could be easily removed in the future, and there's a test for it (the one for the company with id 00256081), so if it is removed and it shouldn't be, I should know about it rather soon. Fix #242 The test querying the service is marked as "skipped" because it uses the Internet to actually query the live service and I don't want to query it when I'm running my tests in dev env for example. But I'd like to run the tests someday, so I've introduced a way to run all skipped tests, just define an environment variable `TEST_CASE_RUNNER_INCLUDE_SKIPPED=1` and run the test case again. Will also do it automatically with GitHub Actions.
spaze
added a commit
that referenced
this issue
Nov 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Something something country code
The text was updated successfully, but these errors were encountered: