Base64 encode serialized publicKeyDetail #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm running into issues where the
SslCertificateinstance can't be serialized for a queue job, due to binary "malformed UTF-8" characters is some of thepublicKeyDetail.I'm specifically running into this in the
laravel-uptime-monitorpackage, when a certificate is included in a queuedCertificateCheckSucceededevent. See here:spatie/laravel-uptime-monitor#359
This PR base64 encodes the
publicKeyDetailpart of the certificate when serializing, and handles decoding on unserialize.I have this fork installed in my own app, and have verified it resolves the issue.
Test case added to verify serialize/unserialize works properly, and that we can
json_encodea serialized certificate.