Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uppercase port option for scp #55

Merged
merged 1 commit into from
Nov 24, 2021
Merged

uppercase port option for scp #55

merged 1 commit into from
Nov 24, 2021

Conversation

timrspratt
Copy link
Contributor

@timrspratt timrspratt commented Nov 23, 2021

It appears in the refactor into extra options in 1.7.0 that this line was removed:

1.6.0...1.7.0#diff-5d960cb119d12ad8d1d5a0e2075f46ea699e824926b237972eedae4a8a0ac9a6L208

The SCP option is an uppercase -P, but with the refactor, this is now imploding the -p

This is resulting in a failure to run any upload command using scp (even when using port 22)

@timrspratt
Copy link
Contributor Author

Apologies, the link appeared to lose the #.

This was removed:
Screenshot 2021-11-23 at 21 05 45

This was added:
Screenshot 2021-11-23 at 21 06 00

Since it needs to be lowercase for the usual ssh connection, I've detected the array key port and modified it. There may be a nicer way though if anyone has an idea?

@freekmurze freekmurze merged commit 2e44365 into spatie:main Nov 24, 2021
@freekmurze
Copy link
Member

Going to merge this for now, and improve on it later. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants