Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing time zone information when exporting asStructuredData #121

Closed
jroedel opened this issue Jun 17, 2019 · 2 comments
Closed

Missing time zone information when exporting asStructuredData #121

jroedel opened this issue Jun 17, 2019 · 2 comments
Assignees

Comments

@jroedel
Copy link

jroedel commented Jun 17, 2019

Hey guys, great work with this package!

I'm exporting structured opening hours data to a Place and I need the information of the timezone to be encoded. I'm creating the object using the OpeningHours::create static method with a time zone passed, but it appears that the timezone is never referenced elsewhere in the code.

Could we tack on the offset according to the schema.org Time spec if there's a timezone set?

@kylekatarnls
Copy link
Collaborator

Of course we should. Good point. I will check if there is already a way to do that or if we need to add some parameter.

@kylekatarnls
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants